Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debian changelog and don't enforce apparmor profile in postinst #117

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Dec 19, 2019

Towards freedomofpress/securedrop-workstation#364
In #116 we've introduced apparmor support but discovered, after merging 2 issues:

  1. if the kernel is not running 4.14.158 or above, the postinst for the client will fail when attempting to enforce the apparmor profile, resulting in a potentially broken template
  2. The debian changelog was not updated.

To immediately resolve (and not break nightlies), let's merge this ASAP and enforce the apparmor profile via /rw/config/rc.local in the securedrop-workstation salt logic as part of freedomofpress/securedrop-workstation#364

Test plan:

  • build securedrop-client on this branch: PKG_VERSION=0.0.11 PKG_PATH=../securedrop-client/dist/securedrop-client-0.0.11.tar.gz make securedrop-client
  • file name is securedrop-client_0.0.11+buster_all.deb
  • securedrop-client built on this branch can be installed (and postinst does not fail) in a qubes PVH kernel or any other kernel without apparmor support
  • /etc/apparmor.d/usr.bin.securedrop-client is still present

This will prevent the install operation from failing on PVH kernels or HVM kernels < 4.14.158
Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Changelog looks OK. Client installs and runs OK on PVH sd-svs template/VM. Profile is present but not enforced.

@rmol rmol merged commit 70aacb8 into master Dec 19, 2019
@rmol rmol deleted the update-changelog-and-no-aa-enforce branch December 19, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants